[PATCH 0/6] s3-spoolss: Add printer port generation

[Justin Chevrier]

On Sun, Oct 30, 2011 at 9:10 PM, David Disseldorp <ddiss at suse.de> wrote:
> On Wed, 31 Aug 2011 15:03:08 -0400
> Justin Chevrier <jchevrier at gmail.com> wrote:
>
>> The following patch series (based on the latest GIT) expands printer port support in Samba.
>
> Thanks a lot for this set of changes Justin, sorry for the long delay in
> getting to them. Overall they look very good, I have a few (mostly
> cosmetic) suggestions for which I'll respond per patch.
>
Thanks for the review David!
>> Notes:
>>
>> I'm not making use of the 'enumports_hook' function, so there is no ability to use a shell command on enumeration of ports. Not sure if this is desired (aka we're heading towards everything being in the registry), or if both need to be an option. I've left all of the enumports_hook functionality in place, I'm just not calling it.
>
> The "enumports command" hook will need to be plumbed back in to ensure
> these changes do not break existing deployments using this
> functionality.
>
> Cheers, David
>
Okay, will do.