Patch for bug #8544

Gémes Géza geza at kzsdabas.hu
Sat Oct 29 09:12:15 MDT 2011


2011-10-29 10:34 keltezéssel, Jelmer Vernooij írta:
> On Tue, 2011-10-25 at 21:08 +0200, Gémes Géza wrote:
>>> Please just directly import from the samba module rather than looking at
>>> its internals. E.g.:
>>>
>>> "from samba import generate_random_password"
>>>
>>> Cheers,
>>>
>>> Jelmer
>> Hi,
>>
>> Changed that.
> Thanks. One more thing: the handling of the random_password variable is
> still a bit odd - the possible values are None or True, rather than
> False or True, which would make more sense.
>
> Other than that, I think this is ready to land.
>
> Cheers,
>
> Jelmer
Fixed.

Also updated the patch at the bug report.

Cheers

Geza
-------------- next part --------------
A non-text attachment was scrubbed...
Name: samba-tool.diff
Type: text/x-patch
Size: 2949 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20111029/08e26424/attachment.bin>


More information about the samba-technical mailing list