bda9752 s3-netlogon: Fix setting the machinge account password - needs to be in 3.6.x ?
Jeremy Allison
jra at samba.org
Thu Oct 27 11:02:47 MDT 2011
Hi Andreas,
Great work on the uid wrapper, but I think this bugfix:
git diff 62ccae32297683815da608cfb938573784614cf8..bda9752b1036c4d4db76a526a79a091419bf757c
diff --git a/source3/rpc_server/netlogon/srv_netlog_nt.c b/source3/rpc_server/netlogon/srv_netlog_nt.c
index dc0c33d..0c94c5b 100644
--- a/source3/rpc_server/netlogon/srv_netlog_nt.c
+++ b/source3/rpc_server/netlogon/srv_netlog_nt.c
@@ -1155,6 +1155,7 @@ static NTSTATUS netr_set_machine_account_password(TALLOC_CTX *mem_ctx,
goto out;
}
+ become_root();
status = samr_find_machine_account(mem_ctx,
h,
account_name,
@@ -1162,6 +1163,7 @@ static NTSTATUS netr_set_machine_account_password(TALLOC_CTX *mem_ctx,
NULL,
NULL,
&user_handle);
+ unbecome_root();
if (!NT_STATUS_IS_OK(status)) {
goto out;
}
@@ -1205,12 +1207,14 @@ static NTSTATUS netr_set_machine_account_password(TALLOC_CTX *mem_ctx,
info->info18 = info18;
+ become_root();
status = dcerpc_samr_SetUserInfo2(h,
mem_ctx,
&user_handle,
UserInternal1Information,
info,
&result);
+ unbecome_root();
if (!NT_STATUS_IS_OK(status)) {
goto out;
}
Needs to be in 3.6.next. Can you confirm please ? If so I'll log
a bug and drive this through.
Thanks !
Jeremy.
More information about the samba-technical
mailing list