[PATCH] create python test for samba-tool time command

[Andrew Bartlett]

On Mon, 2011-10-24 at 10:31 -0400, Sean Dague wrote:
> On 10/23/2011 06:12 PM, Jelmer Vernooij wrote:
> > This file lacks a copyright header - does the source test pass for you?
> 
> Source test? Is there something I should be running here?
> 
> >> +# # domain stuff
> >> +# "DOMAIN",
> >> +# "REALM",
> >> +
> >> +# # domain controller stuff
> >> +# "DC_SERVER",
> >> +# "DC_SERVER_IP",
> >> +# "DC_NETBIOSNAME",
> >> +# "DC_NETBIOSALIAS",
> >> +
> >> +# # domain member
> >> +# "MEMBER_SERVER",
> >> +# "MEMBER_SERVER_IP",
> >> +# "MEMBER_NETBIOSNAME",
> >> +# "MEMBER_NETBIOSALIAS",
> >> +
> >> +# # rpc proxy controller stuff
> >> +# "RPC_PROXY_SERVER",
> >> +# "RPC_PROXY_SERVER_IP",
> >> +# "RPC_PROXY_NETBIOSNAME",
> >> +# "RPC_PROXY_NETBIOSALIAS",
> >> +
> >> +# # domain controller stuff for Vampired DC
> >> +# "VAMPIRE_DC_SERVER",
> >> +# "VAMPIRE_DC_SERVER_IP",
> >> +# "VAMPIRE_DC_NETBIOSNAME",
> >> +# "VAMPIRE_DC_NETBIOSALIAS",
> >> +
> >> +# # server stuff
> >> +# "SERVER",
> >> +# "SERVER_IP",
> >> +# "NETBIOSNAME",
> >> +# "NETBIOSALIAS",
> >> +
> >> +# # user stuff
> >> +# "USERNAME",
> >> +# "USERID",
> >> +# "PASSWORD",
> >> +# "DC_USERNAME",
> >> +# "DC_PASSWORD",
> >> +
> >> +# # misc stuff
> >> +# "KRB5_CONFIG",
> >> +# "WINBINDD_SOCKET_DIR",
> >> +# "WINBINDD_PRIV_PIPE_DIR",
> >> +# "NMBD_SOCKET_DIR",
> >> +# "LOCAL_PATH"
> >> +
> >> +# These can all be accesses via os.environ["VARIBLENAME"] when needed
> > s/VARIBLENAME/VARIABLENAME/
> >
> > Rather than duplicating this list here, it would probably be better to
> > point at the master list of the variables. The risk of duplicating it is
> > that it will get out of date when the main list gets changed.
> 
> Is there a master list somewhere? I just went and found it in 
> selftest.pl, and it seemed confusing to tell folks to read a perl file 
> when writing a python test, especially if they weren't heavily 
> experienced with both.

To the extent that there is a the master list, the one in selftest.pl
and the target modules are that.  This is the master script controlling
the selftest system.  The language is unimportant, this system controls
C, python and perl tests.

I've criticised others for maintaining separate files with lists of
these variables, and the same criticism applies here.  I think any
second copy of this list risks getting dangerously out of date. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org