[PATCH] smb2 FSCTL_SRV_COPYCHUNK support

David Disseldorp ddiss at suse.de
Wed Oct 19 10:09:46 MDT 2011


On Wed, 19 Oct 2011 15:47:50 +0200
"Stefan (metze) Metzmacher" <metze at samba.org> wrote:

> I pushed all the header related stuff to autobuild.

Thanks.

> > I've reworked the existing SMB2 ioctl handler code to use separate
> > source files per ioctl device type. Please let me know if this is
> > what you had in mind:
> 
> Partly, I'll reply more detailed in the next days (if not please ping
> me again).
> 

Here's the new round of copychunk changes, based against
smb2_ioctl_split_dev_type for now. I'll rebase them again with your
detailed response.

Changes since smb2_copychunk_rb2:
- fixes for SMB2 ioctl error reporting / handling in line with MS-SMB2
  3.3.4.4
- basic data integrity checks for the copychunk tests.
- rebased on top of smb2_ioctl_split_dev_type, with some commits
  squashed

http://git.samba.org/?p=ddiss/samba.git;a=shortlog;h=refs/heads/smb2_copychunk_rb4

The following changes since commit
27236e8c2657c536721da1ef1e3ec7c3c67afd26:

  s3-smb2: split ioctl handler code on device type (2011-10-19 17:27:51
  +0200)

are available in the git repository at:
  git://git.samba.org/ddiss/samba.git smb2_copychunk_rb4

David Disseldorp (11):
      idl: add copychunk and request_resume_key ioctl definitions
      s4-torture: Add tests for the smb2 copychunk ioctl
      s3-server: add smb2 FSCTL_SRV_REQUEST_RESUME_KEY support
      s3-vfs: add copy_chunk vfs hook
      s3-server: add support for smb2 FSCTL_SRV_COPYCHUNK
      s3-server: report copychunk limits in invalid param response
      s4-torture: split common copychunk ioctl test code into helpers
      s3-vfs: add vfs_btrfs module
      s4-torture: add smb2 copychunk ioctl tests
      s4-torture: smb2 copychunk data integrity checks
      s3-server: remove smb2 ioctl error response assumption

 examples/VFS/skel_opaque.c           |   12 +
 examples/VFS/skel_transparent.c      |   13 +
 librpc/idl/ioctl.idl                 |   33 ++
 librpc/idl/wscript_build             |    2 +-
 librpc/wscript_build                 |    5 +
 source3/Makefile.in                  |    7 +
 source3/configure.in                 |   13 +
 source3/include/vfs.h                |   15 +
 source3/include/vfs_macros.h         |    5 +
 source3/modules/vfs_btrfs.c          |   77 ++++
 source3/modules/vfs_default.c        |   28 ++
 source3/modules/vfs_full_audit.c     |   20 +
 source3/modules/wscript_build        |    9 +
 source3/smbd/smb2_ioctl.c            |   73 +++-
 source3/smbd/smb2_ioctl_network_fs.c |  141 ++++++++
 source3/smbd/vfs.c                   |   13 +
 source3/wscript                      |   11 +
 source3/wscript_build                |    2 +-
 source4/libcli/smb2/ioctl.c          |   29 ++-
 source4/torture/smb2/ioctl.c         |  645
 +++++++++++++++++++++++++++++++++-
 source4/torture/smb2/wscript_build   |    2 +- 21 files changed, 1129
 insertions(+), 26 deletions(-) create mode 100644 librpc/idl/ioctl.idl
 create mode 100644 source3/modules/vfs_btrfs.c




More information about the samba-technical mailing list