[SCM] Samba Shared Repository - branch master updated
jelmer at samba.org
Tue Oct 18 04:08:30 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 10/18/2011 11:55 AM, Michael Adam wrote:
> Hi Andrew,
> Andrew Bartlett wrote:
>> On Mon, 2011-10-17 at 14:48 +0200, Michael Adam wrote:
>>> Hi Andrew,
>>> any clues about the typo SIGCHILD (instead of SIGCHLD) that is
>>> still in selftest.pl? Anyone? I did not have time to think this
>>> through properly, but every now and then I notice that
>>> "make test" keeps telling me:
>>> "No such signal: SIGCHILD at ../selftest/selftest.pl line 179."
>>> Cheers - Michael
>> As Jelmer intends to rewrite selftest.pl in python, I think the correct
>> fix is to just revert my change.
> Ah yes, the python cures it all thing... ;-)
Actually, this isn't just because Python is the language-of-the-week.
selftest/target/*.pm has become a mess over the last couple of years,
mostly because new additions to it are copy-n-pasted from elsewhere. It
needs thorough cleaning up anyway.
We have Python bindings for a lot of our setup code. If
selftest/target/*.pm was in Python, it could directly use those bindings
rather than shelling out. The Python Subunit producers/consumer library
is much more mature than the Perl one.
If we're going to rewrite large chunks of selftest/target/*.pm anyway,
we might as well take advantage of those existing bindings and libraries.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the samba-technical