[PATCH] [RFC] moving samba tool tests to dedicated directory

Jelmer Vernooij jelmer at samba.org
Mon Oct 17 15:44:09 MDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/17/2011 11:42 PM, Sean Dague wrote:
> On 10/17/2011 05:27 PM, Jelmer Vernooij wrote:
>> They're basically blackbox tests. These tests verify the individual
>> subcommands as they would be called on the command-line. I'm not sure if
>> there is much value calling out to a new subprocess, that just slows the
>> tests down. We already have some basic real blackbox tests that verify
>> the really tiny wrapper in scripting/bin/samba-tool works correctly.
>
> Ok, I can hook in there. Would it make sense to add a subdirectory to
tests for samba-tool commands? It seems like a lot of different things
are tested in that directory besides just samba-tool and some logical
seperation from a maintenance perspective might be nice.
Yeah, that's a good idea. Especially as we'll hopefully end up with a
lot of tests for samba-tool... :-)

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOnKGoAAoJEACAbyvXKaRX6FMQAKlLJecqYTkfIlCtVaNlu539
VqzA2HORnlc0VzUEWyAC2/gmNk0uTx8aNVc5C+clYquK1IovRYovKoy9XLTHCC55
CO8crc3LbILaElJV2HfS+cA1OOg60BJuDlHkVXSJnvvlL4A2rtBrbZYLQ+de/a1M
LcMLdOv2YRiysa/XIy0S7utmfPBMFeFojZP1zTSttU3SuM+z7+JShjo5KY8VA++m
deTjkF/UW+yqVMj6kH8e5HN+H6wN4MwKQxX8y9TncfVf5dMvRvIn65lkksWaAGUj
FUq3+C/ES6LQofjQnAxJAd2Q+Uv33tpmRJx6ZD74K7yNqGT9nHTVmcws4VqT1STn
EfbYlyRMI3ht9gWe7kuysUk/G5inOnNLrCo4ce7rB4nNs0LmvOtN23eMbTZnZ5Ze
dhUDajnA8B8FYTvz8TaJYKdIWH+bSEwplvyiVTFmGNXjzIo/cj0g3vA02bMD4xxI
WxKpVcJWf72o32g6MRaH7PHCp1QhZfBObdf02xQfMHuasf9NkqI5pljqeplqC9Pt
6fLsZAvGvA4vgcc7wOuihDEDbpMB8wJ39AyB/+zY+JV8KhoW+Sn/ZfjyFhyID9Pa
rlJiw7yTMH7+Citkpmbp9K1zngqj8i1CM//k++nfQ4lkXTmU4wSV1QlgnmnbXyIX
C529GsE3SZyAGgws15a5
=cBi/
-----END PGP SIGNATURE-----



More information about the samba-technical mailing list