[PATCH] [RFC] moving samba tool tests to dedicated directory
jelmer at samba.org
Mon Oct 17 15:27:13 MDT 2011
-----BEGIN PGP SIGNED MESSAGE-----
On 10/17/2011 10:58 PM, Sean Dague wrote:
> On 10/17/2011 04:44 PM, Jelmer Vernooij wrote:
>> source4/scripting/python/samba/tests/netcmd.py IIRC
> Those seem to not be blackbox tests, but instead more unit tests inside
of samba tool.
> What I'd really like is effective blackbox testing of samba-tool so
that we know that "samba-tool FOO ... " when run on the command line
does what we expect, or at least doesn't do something unexpected (like
throw an exception).
They're basically blackbox tests. These tests verify the individual
subcommands as they would be called on the command-line. I'm not sure if
there is much value calling out to a new subprocess, that just slows the
tests down. We already have some basic real blackbox tests that verify
the really tiny wrapper in scripting/bin/samba-tool works correctly.
> For these kinds of tests should I just put them in
Yep, that's probably the right place for blackbox tests written in Python.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
-----END PGP SIGNATURE-----
More information about the samba-technical