[PATCH] [RFC] moving samba tool tests to dedicated directory

[Jelmer Vernooij]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 10/17/2011 10:58 PM, Sean Dague wrote:
> On 10/17/2011 04:44 PM, Jelmer Vernooij wrote:
>> source4/scripting/python/samba/tests/netcmd.py IIRC
>
> Those seem to not be blackbox tests, but instead more unit tests inside
of samba tool.
>
> What I'd really like is effective blackbox testing of samba-tool so
that we know that "samba-tool FOO ... " when run on the command line
does what we expect, or at least doesn't do something unexpected (like
throw an exception).
They're basically blackbox tests. These tests verify the individual
subcommands as they would be called on the command-line. I'm not sure if
there is much value calling out to a new subprocess, that just slows the
tests down. We already have some basic real blackbox tests that verify
the really tiny wrapper in scripting/bin/samba-tool works correctly.
>
> For these kinds of tests should I just put them in
source4/scripting/python/samba/tests/blackbox?
Yep, that's probably the right place for blackbox tests written in Python.

Cheers,

Jelmer

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOnJ2xAAoJEACAbyvXKaRXU7cP/0HC/NrMBoScfrknbS+++Fh2
O/x6JIihJCkcLw2LS41siB1V/eqcRQDGyvOmSIMsLJoYW1b4eP0KQ18P8xyB3Sl8
Z1XmXGTmPqRL9XFemTec0/uu3RQ5rWNCSH6TMHQ76NnCFWXPOZ6G+StENDZFI/8n
GiqQc8dwffGAjD7WOljS6zH3Y43a7L44GF7kYrQSOgntdLLIkadPKJWN1cpp37Zv
tV7aV8ZKcht7zZRkp17b8n9ArsT71bX76wSalLwA+D7eGnuhFPf4fpbexAQthqzL
syNGPj7GTcqxOyREnbMcQ2sMuKO29hv+NJL0RpaGx0go8BaFRSvcua9Wd7RUuecC
YiAwZ8JI9XhE2mIPlWXr3NZAULAwC160iXyf1WgpWlngaNcLpM5V9dIw7VMfvTwq
nVwtn6btCmekBeXntJT8w7aH4c424BxrmO+NBD3s6LySoBcN/kIRI0iHYQwcNT8x
wqQA/7qcy9qOOYUIqWIuFYr2AFLxu5sY3YnRzl/NnU9Uc15a/id21GsRg6DJfPt6
paPDm54qVyavX1Ww7jXHlxIIZiSHKsh+OArpdYRX1UQlZ/8jCACB/ppHyMV2ZB+M
b1ddp9NaPEHXSXikG7aWprk+sPycAdSsGGUJMIOQh+gqgWoBX3K3NOIxqGvzQozy
UVL9Y+MVp74LO5lLOnHF
=Jchl
-----END PGP SIGNATURE-----