--kerberos fix

Jelmer Vernooij jelmer at samba.org
Wed Oct 12 19:01:44 MDT 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Giampaolo,

On 10/12/2011 04:14 PM, Giampaolo Lauria wrote:
> While looking at your fix, I noticed that the function to handle the
> --kerberos option in class CredentialsOptionsDouble was not modified and
> is still as:
>
> def _set_kerberos2(self, option, opt_str, arg, parser):
> if bool(arg) or arg.lower() == "yes":
> self.creds2.set_kerberos_state(MUST_USE_KERBEROS)
> else:
> self.creds2.set_kerberos_state(DONT_USE_KERBEROS)
>
> Do we want a different logic for this type or was it just an oversight?
Thanks, that's a good point.

I've now refactored the parsing of this code into a new function which
is used by both _set_kerberos and _set_kerberos2.

Cheers,

Jelmer
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOljh4AAoJEACAbyvXKaRXAkYP/1eRzFGH+LFNQTzSemyonFJQ
gJ3/bPJZ8wJiDbJVk8UclHC0l3N1oJwwDeVrxSm5H827h77aZxteAZ+v4RoYLVvy
TNSb7gyWfz/qwHCbm5HUv3FnthaNozTzr+6/NKfx2q4Ed2ksgKFsrlUnT8TWN/X0
dfgmXLY7U4YIBtHDqn0rXXpgF4KIXeQuZ8RUFTb+buBWuAGAbkKIfO2XOXm6k9wx
dWeFe53IB/JmpWEmxn8JFYajlRiitlB8bbep2L8A29rk+hp7CBp9saWehmjdIJeX
5vfmxB5uCctrMpDk3d5ndD+tAbG1fTmdyjHmXkx9ChrNaA5n8ylpi68HYkxMD6tK
L0fPwfkPawz73P9XhDiiS2Soiq0eaT1RHnLMP6W403eLtY27dmVLqnu9Se6LFREi
R/Jqj2KxxeMkLs2T+0W62ph508FFGnSB8YGpwQ2EX8SafQmVvaVqv1GPoGblSrJd
xF0QUCp/Sdst9IXVv7Lrn8tJUt68LVT8FB7sG2vnXrHIQsjL8LlwRvMU+lo3/8CY
gIv5UdboP+kGHwFNfSK1x+Se/77wTs1YiFMJqcT7ImGHhuHQbjzK/BGRl80puEId
BXzyW2f7vVYmv96jX2aIO9k6hd1wn187rPDYL++xtt8Wlheol2KgDRADs+/Rlf/+
ayedkSdoSRy0RkdU7Cml
=gp9a
-----END PGP SIGNATURE-----



More information about the samba-technical mailing list