lauria at us.ibm.com
Wed Oct 12 09:35:37 MDT 2011
After having looked at the options some more, I now see the reason for
having two different classes. However, I still think that we could rewrite
the two classes a bit differently so that we don't have to implement those
fcns having the same logic twice.
From: Giampaolo Lauria/Poughkeepsie/IBM at IBMUS
To: Jelmer Vernooij <jelmer at samba.org>
Cc: samba-technical at samba.org
Date: 10/12/2011 11:05 AM
Subject: --kerberos fix
Sent by: samba-technical-bounces at lists.samba.org
Thanks for your quick answers.
While looking at your fix, I noticed that the function to handle the
--kerberos option in class CredentialsOptionsDouble was not modified and
is still as:
def _set_kerberos2(self, option, opt_str, arg, parser):
if bool(arg) or arg.lower() == "yes":
Do we want a different logic for this type or was it just an oversight?
In general, could someone explain to me the reason for having two
different classes for these options. It seems like the implementation is
the same for both classes w/ the exception of --ipaddress and the suffix 2
on pretty much all of its fcns and variables. Currently, one class derives
from the other, yet most of the code is duplicated.
I can make the necessary changes once I get your permission and
clarification as to what each class is trying to represent.
More information about the samba-technical