[PATCH 0/5] OpenPrinterEx device mode formname unmarshalling

David Disseldorp ddiss at suse.de
Mon Nov 14 09:59:41 MST 2011


This patch set intends to address bug 8606 - Intermittent print job
failures caused by character conversion errors.

A new (IMO poorly named) to_null IDL attribute is added for specifying
whether character conversion should take place across an entire
character array or just to the null terminator. Feedback appreciated.

Cheers, David


The following changes since commit 72cabbbe50a36986dde823f0ba60abf9052c535a:

  s3:smb2_flush: outbody only needs 4 bytes (2011-11-14 10:01:30 +0100)

are available in the git repository at:
  git://git.samba.org/ddiss/samba.git formname_char_conv_rb2

David Disseldorp (5):
      spoolss: test unmarshalling formname with garbage after null
      ndr: add ndr_pull_charset_to_null()
      idl: add to_null property
      idl: add parser for the to_null property
      idl: add to_null attribute to the spoolss formname array

 librpc/idl/spoolss.idl                   |    2 +-
 librpc/ndr/libndr.h                      |    1 +
 librpc/ndr/ndr_string.c                  |   31 ++++++++++++++++++++++++++++++
 pidl/lib/Parse/Pidl/NDR.pm               |    9 +++++++-
 pidl/lib/Parse/Pidl/Samba4/NDR/Parser.pm |    6 ++++-
 source4/torture/rpc/spoolss.c            |   28 +++++++++++++++++++++++++++
 6 files changed, 74 insertions(+), 3 deletions(-)

More information about the samba-technical mailing list