Example configure.in for VFS modules in examples directory has a problem, it seems

[Richard Sharpe]

Hi,

So, the configure.in has:

----------------------------------------------------------------------------------------
SAMBA_SOURCE="../../source3"
####################################################
# set the location location of the samba source tree
AC_ARG_WITH(samba-source,
[  --with-samba-source=DIR Where is the samba source tree (../../source3)],
[ case "$withval" in
  yes|no)
  #
  # Just in case anybody calls it without argument
  #
    AC_MSG_WARN([--with-samba-source called without argument - will
use default])
  ;;
  * )
    SAMBA_SOURCE="$withval"
    ;;
  esac])

AC_SUBST(SAMBA_SOURCE)
----------------------------------------------------------------------------------------

and then later it has:

----------------------------------------------------------------------------------------
#######################################################
# test whether building a shared library actually works
if test $BLDSHARED = true; then
AC_CACHE_CHECK([whether building shared libraries actually works],
               [ac_cv_shlib_works],[
   ac_cv_shlib_works=no
   # try building a trivial shared library
   if test "$PICSUFFIX" = "po"; then
     $CC $CPPFLAGS $CFLAGS $PICFLAGS -c -o shlib.po
${srcdir-.}/../../tests/shlib.c &&
       $CC $CPPFLAGS $CFLAGS `eval echo $LDSHFLAGS` -o
"shlib.$SHLIBEXT" shlib.po &&
       ac_cv_shlib_works=yes
   else
     $CC $CPPFLAGS $CFLAGS $PICFLAGS -c -o shlib.$PICSUFFIX
${srcdir-.}/../../tests/shlib.c &&
-----------------------------------------------------------------------------------------------

This assumes that one is building in the examples directory. Surely it
should use ${SAMBA_SOURCE} where ${srcdir-.} is given? Perhaps it
should even complain if --with-samba-source is not give so that it
facilitates people building VFSes outside the Samba source tree?

-- 
Regards,
Richard Sharpe