Review on patches for multi-ip handling

Matthieu Patou mat at
Fri Nov 11 15:48:55 MST 2011

Hello Tridge,

On 11/11/2011 04:30, Andrew Tridgell wrote:
> Hi Matthieu,
> I've had a look at these patches, and the others in drs_timebased.
Thanks one more time
> The timeout handling changes in getncchanges could be a bit neater I
> think. I've pushed an alternative implementation to my drs_timebased
> branch for you to take a look at. It adds a flag to the existing
> get_nc_changes_build_object() call instead of having a new
> function.  (I haven't tested it, sorry)
I just had a look, the things that worry me is that we can return an 
object with no modified attribute and empty metadata, I don't know how 
much this can be a problem. If it's not then I'll take your patch.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list