Patch for bug #8544

Matthias Dieter Wallnöfer mdw at samba.org
Mon Nov 7 00:48:09 MST 2011


Hi Gémes,

(just for information) as far as I heard from Jelmer he was unable to 
push it - unfortunately I don't know the exact details. Did it pass a 
"make test"?

Thanks,
Matthias

Gémes Géza wrote:
> 2011-11-02 15:34 keltezéssel, Jelmer Vernooij írta:
>    
>> On 29/10/11 17:12, Gémes Géza wrote:
>>      
>>> 2011-10-29 10:34 keltezéssel, Jelmer Vernooij írta:
>>>        
>>>> On Tue, 2011-10-25 at 21:08 +0200, Gémes Géza wrote:
>>>>          
>>>>>> Please just directly import from the samba module rather than
>>>>>>              
>> looking at
>>      
>>>>>> its internals. E.g.:
>>>>>>
>>>>>> "from samba import generate_random_password"
>>>>>>
>>>>>> Cheers,
>>>>>>
>>>>>> Jelmer
>>>>>>              
>>>>> Hi,
>>>>>
>>>>> Changed that.
>>>>>            
>>>> Thanks. One more thing: the handling of the random_password variable is
>>>> still a bit odd - the possible values are None or True, rather than
>>>> False or True, which would make more sense.
>>>>
>>>> Other than that, I think this is ready to land.
>>>>
>>>> Cheers,
>>>>
>>>> Jelmer
>>>>          
>>> Fixed.
>>>        
>>      
>>> Also updated the patch at the bug report.
>>>        
>> Thanks, sent off to autobuild. Sorry it took so long.
>>
>> Cheers,
>>
>> Jelmer
>>      
> Thanks for pushing it.
>
> Cheers
>
> Geza
>    



More information about the samba-technical mailing list