where should smb.conf % macros be supported?

Andrew Bartlett abartlet at samba.org
Tue May 31 20:25:23 MDT 2011

On Tue, 2011-05-31 at 13:41 +0200, Michael Adam wrote:
> Hi Andrew,
> I would very much appreciate if this change could be done
> (as Volker has already suggested) one parameter per commit.
> I think it is dangerous to attempt to change too many things
> in one commit. It will make debugging more difficult if
> something breaks.
> Other than that, I agree to making these parameters const!

Thanks.  Looking over the list carefully again made me realise that
'panic action' needs the % subs (for the pid in particular).  It seems
dangerous to have to do allocations in the panic path, so we may wish to
pre-calculate that. 

Other than that, these are now in autobuild.

Andrew bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list