[PATCH] s4:librpc/ndr: add new LIBNDR_FLAG_STR_RAW8 for ndr_pull_string

Sean Finney seanius at seanius.net
Mon May 23 23:55:19 MDT 2011


Hi Andrew,

On Tue, May 24, 2011 at 07:03:30AM +1000, Andrew Bartlett wrote:
> This would seem to be exactly what we need.  
> 
> However, as you have changed the potential size that ndr_string objects
> can be, you also need to update ndr_size_string_array().
> (ndr_size_string() appears incorrect, unused, and can be removed rather
> than fixed).

Great!  Will re-roll the patch this afternoon then.  If I'm doing some
cleanup I might also take a stab at simplifying the logic/LoC of 
ndr_pull_string--but I'll make sure to keep those seperate from the
main patch if I do that.


	sean


More information about the samba-technical mailing list