samba4 / samba-tool patches - rework, patch 0002 of 0002

[Theresa Halloran]

 From f9339208661578bf4f2ffd29a9b7e08566c78acf Mon Sep 17 00:00:00 2001
From: Theresa Halloran <theresahalloran at gmail.com>
Date: Thu, 19 May 2011 16:24:00 -0400
Subject: [PATCH 2/2] s4:samba-tool: Move samba-tool setexpiry to 
samba-tool user setexpiry <user>

---
  source4/scripting/python/samba/netcmd/__init__.py  |    2 -
  source4/scripting/python/samba/netcmd/setexpiry.py |   67 
--------------------
  source4/scripting/python/samba/netcmd/user.py      |   39 +++++++++++-
  source4/setup/tests/blackbox_newuser.sh            |    8 +-
  4 files changed, 42 insertions(+), 74 deletions(-)
  delete mode 100644 source4/scripting/python/samba/netcmd/setexpiry.py

diff --git a/source4/scripting/python/samba/netcmd/__init__.py 
b/source4/scripting/python/samba/netcmd/__init__.py
index ee2e700..d934cf8 100644
--- a/source4/scripting/python/samba/netcmd/__init__.py
+++ b/source4/scripting/python/samba/netcmd/__init__.py
@@ -180,8 +180,6 @@ from samba.netcmd.domainlevel import cmd_domainlevel
  commands["domainlevel"] = cmd_domainlevel()
  from samba.netcmd.setpassword import cmd_setpassword
  commands["setpassword"] = cmd_setpassword()
-from samba.netcmd.setexpiry import cmd_setexpiry
-commands["setexpiry"] = cmd_setexpiry()
  from samba.netcmd.newuser import cmd_newuser
  commands["newuser"] = cmd_newuser()
  from samba.netcmd.netacl import cmd_acl
diff --git a/source4/scripting/python/samba/netcmd/setexpiry.py 
b/source4/scripting/python/samba/netcmd/setexpiry.py
deleted file mode 100644
index bd8ea16..0000000
--- a/source4/scripting/python/samba/netcmd/setexpiry.py
+++ /dev/null
@@ -1,67 +0,0 @@
-#!/usr/bin/env python
-#
-# Sets the user password expiry on a Samba4 server
-# Copyright Jelmer Vernooij 2008
-#
-# Based on the original in EJS:
-# Copyright Andrew Tridgell 2005
-#
-# This program is free software; you can redistribute it and/or modify
-# it under the terms of the GNU General Public License as published by
-# the Free Software Foundation; either version 3 of the License, or
-# (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program.  If not, see <http://www.gnu.org/licenses/>.
-#
-
-from samba.netcmd import Command, CommandError, Option
-
-import samba.getopt as options
-
-from samba.auth import system_session
-from samba.samdb import SamDB
-
-class cmd_setexpiry(Command):
-    """Sets the expiration of a user account"""
-
-    synopsis = "setexpiry [username] [options]"
-
-    takes_optiongroups = {
-        "sambaopts": options.SambaOptions,
-        "versionopts": options.VersionOptions,
-        "credopts": options.CredentialsOptions,
-    }
-
-    takes_options = [
-        Option("-H", help="LDB URL for database or target server", 
type=str),
-        Option("--filter", help="LDAP Filter to set password on", 
type=str),
-        Option("--days", help="Days to expiry", type=int),
-        Option("--noexpiry", help="Password does never expire", 
action="store_true"),
-    ]
-
-    takes_args = ["username?"]
-
-    def run(self, username=None, sambaopts=None, credopts=None,
-            versionopts=None, H=None, filter=None, days=None, 
noexpiry=None):
-        if username is None and filter is None:
-            raise CommandError("Either the username or '--filter' must 
be specified!")
-
-        if filter is None:
-            filter = "(&(objectClass=user)(sAMAccountName=%s))" % 
(username)
-
-        lp = sambaopts.get_loadparm()
-        creds = credopts.get_credentials(lp)
-
-        if days is None:
-            days = 0
-
-        samdb = SamDB(url=H, session_info=system_session(),
-            credentials=creds, lp=lp)
-
-        samdb.setexpiry(filter, days*24*3600, no_expiry_req=noexpiry)
diff --git a/source4/scripting/python/samba/netcmd/user.py 
b/source4/scripting/python/samba/netcmd/user.py
index 5f53263..10e0b8a 100644
--- a/source4/scripting/python/samba/netcmd/user.py
+++ b/source4/scripting/python/samba/netcmd/user.py
@@ -110,7 +110,43 @@ class cmd_user_enable(Command):
              credentials=creds, lp=lp)
          samdb.enable_account(filter)

+class cmd_user_setexpiry(Command):
+    """Sets the expiration of a user account"""

+    synopsis = "%prog user setexpiry <username> [options]"
+
+    takes_optiongroups = {
+        "sambaopts": options.SambaOptions,
+        "versionopts": options.VersionOptions,
+        "credopts": options.CredentialsOptions,
+    }
+
+    takes_options = [
+        Option("-H", help="LDB URL for database or target server", 
type=str),
+        Option("--filter", help="LDAP Filter to set password on", 
type=str),
+        Option("--days", help="Days to expiry", type=int),
+        Option("--noexpiry", help="Password does never expire", 
action="store_true"),
+    ]
+
+    takes_args = ["username?"]
+    def run(self, username=None, sambaopts=None, credopts=None,
+            versionopts=None, H=None, filter=None, days=None, 
noexpiry=None):
+        if username is None and filter is None:
+            raise CommandError("Either the username or '--filter' must 
be specified!")
+
+        if filter is None:
+            filter = "(&(objectClass=user)(sAMAccountName=%s))" % 
(username)
+
+        lp = sambaopts.get_loadparm()
+        creds = credopts.get_credentials(lp)
+
+        if days is None:
+            days = 0
+
+        samdb = SamDB(url=H, session_info=system_session(),
+            credentials=creds, lp=lp)
+
+        samdb.setexpiry(filter, days*24*3600, no_expiry_req=noexpiry)

  class cmd_user(SuperCommand):
      """User management [server connection needed]"""
@@ -119,4 +155,5 @@ class cmd_user(SuperCommand):
      subcommands["add"] = cmd_user_add()
      subcommands["delete"] = cmd_user_delete()
      subcommands["enable"] = cmd_user_enable()
-
+    subcommands["setexpiry"] = cmd_user_setexpiry()
+
diff --git a/source4/setup/tests/blackbox_newuser.sh 
b/source4/setup/tests/blackbox_newuser.sh
index 71c957b..5ce634a 100755
--- a/source4/setup/tests/blackbox_newuser.sh
+++ b/source4/setup/tests/blackbox_newuser.sh
@@ -34,9 +34,9 @@ testit "setpassword" $samba_tool setpassword $CONFIG 
NewUser --newpassword=testp
  testit "setpassword" $samba_tool setpassword $CONFIG NewUser1 
--newpassword=testp at ssw0Rd2

  # check the setexpiry script
-testit "noexpiry" $samba_tool setexpiry $CONFIG NewUser --noexpiry
-testit "noexpiry" $samba_tool setexpiry $CONFIG NewUser1 --noexpiry
-testit "expiry" $samba_tool setexpiry $CONFIG NewUser --days=7
-testit "expiry" $samba_tool setexpiry $CONFIG NewUser1 --days=7
+testit "noexpiry" $samba_tool user setexpiry $CONFIG NewUser --noexpiry
+testit "noexpiry" $samba_tool user setexpiry $CONFIG NewUser1 --noexpiry
+testit "expiry" $samba_tool user setexpiry $CONFIG NewUser --days=7
+testit "expiry" $samba_tool user setexpiry $CONFIG NewUser1 --days=7

  exit $failed
-- 
1.7.3.4