Add -fno-common where supported (WAF only)

Andrew Bartlett abartlet at
Thu May 12 08:43:04 MDT 2011

On Tue, 2011-05-10 at 05:22 +0200, Rusty Russell wrote:
>     Add -fno-common where supported (WAF only)
>     Normally under UNIX, uninitialized non-static global variables get
>     placed in the "common" section, where they are merged at link
> time.
>     This means if two C files define "int debug", they will end up
>     referring to the same variable.  Or if one does "float level" and
> the
>     other does "int level" you'll get an accidental union.
>     Such bugs can be hard to track down; fortunately GCC offers
>     -fno-common to disable this feature.  It didn't reveal any places
>     which need fixing, however).
>     Signed-off-by: Rusty Russell <rusty at>


this breaks 'make SYMBOLCHECK=1', due to __progname in the setprogname
implementation in Heimdal.

Can you look into this, and determine if the Heimdal roken use was
invalid, or if it was deliberately referencing the __progname in the
system libs?  It is fatally reported as a duplicate with my system libs,
when I run that.


Andrew Bartlett

Andrew Bartlett                      
Authentication Developer, Samba Team 

More information about the samba-technical mailing list