Reduce duplicate symbols, merge server_id

Stefan (metze) Metzmacher metze at samba.org
Mon May 2 08:57:30 MDT 2011


Am 02.05.2011 15:32, schrieb Volker Lendecke:
> On Mon, May 02, 2011 at 10:42:41PM +1000, Andrew Bartlett wrote:
>> In my merge-test branch I have some changes to bring down the duplicate
>> symbol count in the top level build.
>>
>> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/merge-test
>>
>> Ronnie, in particular I would like your comment on:
>>
>> s3-server_id Add id2 to server_id to match Samba4
>> http://git.samba.org/?p=abartlet/samba.git/.git;a=commitdiff;h=b7d019d745b015154085b1f16db6c7269bc4d61d
> 
> I think it would be better to rename "struct server_id" in
> either implementation. The purpose just seems different.

I think it makes sense to rename it in s4 for now (together with the
messaging_* functions)

We can unify them when we write a unified messaging layer.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110502/8e11fc75/attachment.pgp>


More information about the samba-technical mailing list