[PATCH] Remove default panic action for --enable-developer

tridge at samba.org tridge at samba.org
Wed Mar 23 05:08:59 MDT 2011

Hi Volker,

 > Here I like the changed default in DEVELOPER mode. It has
 > helped me a lot in the past. Yes, I know that I can set it
 > explicitly, but it is just convenient.

Unfortunately it is also very confusing. Try this with the default
panic action:

 # start smbd
 # killall -SEGV smbd
 # killall -9 smbd
 # try to restart smbd, it won't start

the problem is that system() doesn't close file descriptors, so the
sleep and the shell it is in end up listening on port 139. So smbd
can't restart. It can be pretty confusing that in the default
developer setup, "killall -9 smbd" doesn't cause it all to die so you
can restart.

This is why I noticed it, and why I think it should be removed. Either
that, or:

 - we carefully use close-on-exec everywhere
 - we not use system() in smb_panic() and instead use a fork/exec with
   explicit close of all fds up to the fd limit

Cheers, Tridge

More information about the samba-technical mailing list