[PATCH] Remove default panic action for --enable-developer
abartlet at samba.org
Tue Mar 22 18:15:56 MDT 2011
This patch removes the default panic action for --enable-developer,
which was previously 'sleep 999999'.
This is a problem because like other #ifdef DEVELOPER things, it changes
behaviour and makes reproducing customer problems more difficult. In
this particular case, it meant it was more difficult to test the core
dumping code, or to get a core file at all!
If the developer (or user running with developer settings) knows that
the sleep is in operation (because they set it), they can look for the
deliberately stuck process. However if they don't know (a user running
with developer settings to get better debugging), then it's just
confusing to find resources such as the main socket and any locks etc
still held open.
What do others think?
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Cisco Inc.
More information about the samba-technical