[PATCH] Remove clobber_region() etc

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Mar 22 01:01:34 MDT 2011

On Tue, Mar 22, 2011 at 05:37:12PM +1100, Andrew Bartlett wrote:
> We don't have pstrings any more, so the underlying risk has changed.
> Has anyone found any bugs using this code in the past few years?

I haven't. And, to be honest, I never really understood the
reasoning behind those safe_strcpy things given that we have
strlcpy these days. For me it's always a pain to follow the
these safe_strcpy macros, so simplifying them is worthwile
to me.

> As such I propose to remove the clobber_region() calls and the extra
> functions arguments they required.  What do others think?

Fine by me.

> (The compile-time macros still work, and as they found a bug only today,
> I'm not inclined to remove them.)

Can you explain what and how you found a bug? As I said,
these safe_strcpy macros are pretty much a mystery to me.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list