dirsync review

Matthieu Patou mat at samba.org
Mon Mar 21 06:24:31 MDT 2011

On 21/03/2011 13:45, Matthias Dieter Wallnöfer wrote:
> Hi ekacnet,
> two comments from my side:
> - the indentation sometimes looks a bit strange - I cannot distinguish 
> if this is only gitweb or if you have mixed tabs and whitespaces
Normally it should be tabs, I'll have a look if it's not linked with 
code that I copy pasted from not so correctly formatted files !

> - with "int i" and "int k" in the dirsync implementation I'm still not 
> very happy - I invite you to use the correct downto counting mechanism 
> ("ldb_dn.c" shows how to do that in respect to the DN components)
Let's have a look not sure it could be solved as as you can notice we 
are counting backward from num_values to 0 and if I use an unsigned int 
when k = 0, the next k-- will give me 4294967295 and not -1, I can of 
course cast k when doing a comparison not sure it's much more elegant.


Matthieu Patou
Samba Team        http://samba.org
Private repo      http://git.samba.org/?p=mat/samba.git;a=summary

More information about the samba-technical mailing list