Matthias Dieter Wallnöfer
mdw at samba.org
Mon Mar 21 04:45:43 MDT 2011
two comments from my side:
- the indentation sometimes looks a bit strange - I cannot distinguish
if this is only gitweb or if you have mixed tabs and whitespaces
- with "int i" and "int k" in the dirsync implementation I'm still not
very happy - I invite you to use the correct downto counting mechanism
("ldb_dn.c" shows how to do that in respect to the DN components)
Otherwise they seem pretty fine to me.
Matthieu Patou wrote:
> Hello Andrews & Metze,
> Can one of you have a look at
> It's the dirsync implementation, current implementation didn't deal
> with more than 1 DCs, more exactly if samba4 receive a cookie coming
> from another server it won't be able to deal with it and will return
> all the entries matching the expression, you can see this behavior
> with windows too if have 2 DCs (A and B) you just promoted B (so it
> hasn't sent it's uptodateness vector to A) when you query A you will
> see just its uptodateness vector.
> I've tested it manually and with unit tests it's quite successful I
> get the same results as a w2k3r2 server when used with directory
> aggregation tool called MIIS.
More information about the samba-technical