[PATCH] s4 libcli should not use NTLMv2 if extended security is not negotiated

Stefan (metze) Metzmacher metze at samba.org
Wed Mar 16 07:20:51 MDT 2011

Hi Ambi,

>> It seems that there're a lot of callers of NTLMv2_generate_names_blob(),
>> are you sure the behavior change is correct for all of them?
> You're right, I forgot to do that.
> I'll go through all callers and test out if they still work.
> In case they do, I'll also eliminate the then unused hostname argument to
> NTLMv2_generate_names_blob().

Wouldn't it make sense to just handle hostname == NULL?

This is used a lot in torture code, I guess we should extent our tests
to test both combinations if possible.

A test for the error code in the non extended security ntlmv2 case would
also be nice to


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110316/19862d7b/attachment.pgp>

More information about the samba-technical mailing list