Carry error status in printer list IPC message V2

David Disseldorp ddiss at
Tue Mar 15 07:06:21 MDT 2011


Currently the process forked to fetch printcap information from cups
does not include error status in its IPC message back to the parent.
As a result the parent is unable to differentiate between an empty
printer list and a failure to obtain the information from cups.

This patch-set converts the IPC message to an IDL defined format, which
includes the error status alongside the list of printers.

Version 2:
- Use utf8 string definitions in IDL
- Add printing subsystem dependency for WAF build

Cheers, David

The following changes since commit 420be02a60ee989f27a0eebea575fd64f98742fe:

  s3: Read uidNumber/gidNumber in pdb_ads_sid_to_id (2011-03-15 09:59:55 +0100)

are available in the git repository at:
  git:// bso7994_cups_pcap_idl_v2

David Disseldorp (4):
      idl: define printcap IPC message format
      s3-printing: use printcap IDL for IPC
      s3-printing: remove duplicate cups response processing code
      s3-printing: fix memory leak in print_cups.c

 librpc/idl/printcap.idl       |   17 ++
 librpc/idl/wscript_build      |    3 +-
 librpc/wscript_build          |    5 +
 source3/           |    2 +-
 source3/printing/print_cups.c |  442 +++++++++++++++++------------------------
 source3/wscript_build         |    1 +
 6 files changed, 205 insertions(+), 265 deletions(-)
 create mode 100644 librpc/idl/printcap.idl

More information about the samba-technical mailing list