[PATCH 1/4] idl: define printcap IPC message format

Stefan (metze) Metzmacher metze at samba.org
Fri Mar 11 18:03:14 MST 2011


Hi David,

>  librpc/idl/printcap.idl  |   17 +++++++++++++++++
>  librpc/idl/wscript_build |    3 ++-
>  librpc/wscript_build     |    5 +++++
>  3 files changed, 24 insertions(+), 1 deletions(-)
>  create mode 100644 librpc/idl/printcap.idl

> diff --git a/librpc/idl/printcap.idl b/librpc/idl/printcap.idl
> new file mode 100644
> index 0000000..2b8469c
> --- /dev/null
> +++ b/librpc/idl/printcap.idl
> @@ -0,0 +1,17 @@
> +#include "idl_types.h"
> +[
> +	pointer_default(unique)
> +]
> +interface printcap
> +{
> +	typedef struct {
> +		astring *name;
> +		astring *info;
> +	} pcap_printer;

Please don't use 'astring' in new code, as it's not valid NDR.

I also guess we want to use utf8.

For mandatory values use this:

[charset(UTF8),string] uint8 var[]

For optional values this:

[charset(UTF8),string] uint8 *var

> +	typedef [public] struct {
> +		NTSTATUS status;
> +		uint32 count;
> +		[size_is(count)] pcap_printer printers[];
> +	} pcap_data;
> +}

That's only use between two processes of the same smbd binary, right?
Otherwise it would make sense to introduce some kind of version
similar to xattr_NTACL.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110312/1ee9e8eb/attachment.pgp>


More information about the samba-technical mailing list