s4: "samdb_msg_add_string" remove patchset

[Stefan (metze) Metzmacher]

Am 02.03.2011 09:36, schrieb Matthias Dieter Wallnöfer:
> Andrew Bartlett wrote:
>> The main issue I have with that patch is that the various controls and
>> their use is still rather undocumented - and the use seems more like
>> 'add controls until it works'.
>>    
> Unfortunately the relax control messed a bit up our code - including by
> contributions from my side.
>> Also, controls are not the preferred way to handle this any more -
>> another undocumented change that you may not be aware of is that Tridge
>> and I are trying to move more of this kind of thing to per-element
>> flags.  That makes it much clear which exact thing must be allowed - but
>> these are only set from ldb modules at the moment.
>>    
> Ah, interesting: is it possible to see a patch preview? So I could
> understand better how this works.
> 
> I hope that you've nothing against if I'm only pushing this patch:
> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=commitdiff;h=35697c526dff2ff75bed4e11223cfb4f9492a9b1
> (better comment).

Why do we use the relax control for that one?
The provision code should be the only code that creates an object with a
given guid.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20110302/2b93f94f/attachment.pgp>