s4: "samdb_msg_add_string" remove patchset

Andrew Bartlett abartlet at samba.org
Wed Mar 2 01:09:25 MST 2011

On Tue, 2011-03-01 at 23:05 +0100, Matthias Dieter Wallnöfer wrote: 
> I've also tried hard to improve the provision flag patches: 
> http://gitweb.samba.org/samba.git/?p=mdw/samba.git;a=log;h=refs/heads/provision_flag
> I think that in this state the changes should be viable for us (I've 
> tried to split up the important changes).

The main issue I have with that patch is that the various controls and
their use is still rather undocumented - and the use seems more like
'add controls until it works'.  

Also, controls are not the preferred way to handle this any more -
another undocumented change that you may not be aware of is that Tridge
and I are trying to move more of this kind of thing to per-element
flags.  That makes it much clear which exact thing must be allowed - but
these are only set from ldb modules at the moment. 

I just think we might need to do some more refinement on a design here.


Andrew Bartlett
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.

More information about the samba-technical mailing list