[SCM] Samba Shared Repository - branch master updated

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Mar 1 09:01:06 MST 2011

On Tue, Mar 01, 2011 at 07:55:28AM -0500, simo wrote:
> If you want to see this patch in a slightly better form you can use a
> command like this:
> git showh -M -C --patience 5f5ca913b7abfcf95782339fac2dc8c1541b1126
> With this one git is told to detect the rename and does show only the
> differences.

Ok, thanks. Then I rephrase my comment a bit. It would be
highly desirable to make small patches to both
implementations until there is no difference anymore or the
diff is really trivial. That patch is almost 2000 lines,
which is for my taste a LOT too much for a single patch
unless there is a very good reason for this.

Please in the future divide that kind of patches into much
smaller chunks if you do not want to actively feed
resistance against any kind of changes to Samba3.

With best regards,

Volker Lendecke

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list