[SCM] Samba Shared Repository - branch master updated

simo idra at samba.org
Tue Mar 1 05:55:28 MST 2011

On Tue, 2011-03-01 at 07:35 +0100, Volker Lendecke wrote:
> On Tue, Mar 01, 2011 at 04:33:01AM +0100, Andrew Bartlett wrote:
> > The branch, master has been updated
> >        via  5f5ca91 lib/util: new merged debug system
> >        via  4acef31 lib/util move debug.[ch] out of the way
> >       from  b1f68b6 s4-libnet_vampire: Ignore some attributes when building working schema cache
> > 
> > http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master
> > 
> > 
> > - Log -----------------------------------------------------------------
> > commit 5f5ca913b7abfcf95782339fac2dc8c1541b1126
> > Author: Andrew Bartlett <abartlet at samba.org>
> > Date:   Thu Feb 24 16:14:03 2011 +1100
> > 
> >     lib/util: new merged debug system
> >     
> >     This is the s3 debug system, with a number of changes to tidy it up
> >     for common use.  The debug class system is simplified by the removal of the
> >     ISSET table, the system no longer attempts to cope with assignment of
> >     DEBUGLEVEL, and the full class table is always available (rather than
> >     just DEBUGLEVEL_CLASS[DBCG_ALL]) from startup.  It is also no longer
> >     confusingly described as a hack, but as the initial table.
> The way git diff / git whatchanged works makes it more
> difficult than necessary to compare the actual code changes
> if you make changes and move the files at the same time.
> Next time, can you please split those two changes into two
> commits?


If you want to see this patch in a slightly better form you can use a
command like this:
git showh -M -C --patience 5f5ca913b7abfcf95782339fac2dc8c1541b1126

With this one git is told to detect the rename and does show only the

you can use the same arguments for generating better patches when you
want to send them around for review, like this:
 git format-patch -M -C --patience --full-index -1


Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>

More information about the samba-technical mailing list