s3-talloc Change TALLOC_ZERO_P() to talloc_zero()
jra at samba.org
Thu Jun 23 10:01:04 MDT 2011
On Thu, Jun 23, 2011 at 12:21:25PM +0200, Michael Adam wrote:
> Andrew Bartlett wrote:
> > On Fri, 2011-06-10 at 13:25 +0200, Michael Adam wrote:
> > Rest assured I would never slip in 'fixup' changes unannounced into a
> > commit such as this.
> Yeah, I did not assume that, either. :-)
> > > Don't worry about changin the code, please: I am just changing/fixing
> > > this code file anyways. But I was just curious because I stumbled
> > > over this conflict when I now tried to rebase changes I made... :-)
> > >
> > > Again, my lesson is: Try to change as little files in one
> > > commit as possible.
> > There are still a number of other issues (types without _t, True and
> > False) that come up every time I move code from source3 to the common
> > code, so I am very keen to learn the lessons here: How would you have
> > handled this better?
At some point I was planning to do a remove of "False", "True" and
fix the compile of everything that breaks (converting to "false" and
"true"). That would be a big change but a very targetted one. Is
that something people would support ?
More information about the samba-technical