Changing the hash in S3?

simo idra at samba.org
Wed Jun 15 20:05:13 MDT 2011


On Thu, 2011-06-16 at 11:15 +0930, Rusty Russell wrote:
> As part of my cleanups wrt TDB2, I've switched several places from using
> TDB1's tdb_jenkins_hash to CCAN's hash_any function (where TDB's came from).
> 
> The difference is that the CCAN version varies with endian; the TDB one
> is always little endian (with an associated penalty on big endian
> machines).
> 
> Jeremy, Volker, does it matter?  If these hashes are supposed to be
> stable on disk across upgrades, I'll switch it to hash_stable() (which
> is *exactly* the same hash as tdb_jenkins_hash).

It does matter, we always tried to have a compatible disk format so that
tdb (and ldb) files can be easily moved from a big endian machine and
analyzed on a little endian one.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>



More information about the samba-technical mailing list