smbtorture: test case and implementation mismatched in RAW-SFILEINFO

Kazuo Umemoto umemoto-k at sei-networks.com
Mon Jun 13 20:57:42 MDT 2011


I am testing Samba with smbtorture. (using Samba 3.5.8)
I think that there is process skipped in the following places of
source4/torture/raw/setfileinfo.c

--------------------------------------------------------
 	printf("test mode_information level\n");
 	sfinfo.mode_information.in.mode = 2;
 	CHECK_CALL_FNUM(MODE_INFORMATION, NT_STATUS_OK);
 	CHECK_VALUE(MODE_INFORMATION, mode_information, mode, 2);

+	sfinfo.mode_information.in.mode = 0;
 	CHECK_CALL_PATH(MODE_INFORMATION, NT_STATUS_OK);
 	CHECK_VALUE(MODE_INFORMATION, mode_information, mode, 0);

 	sfinfo.mode_information.in.mode = 1;
--------------------------------------------------------

reading http://samba.org/samba/devel/smbtorture-raw-functions.txt ,
setpathinfo send with mode 0.
However, implementation is sending setpathinfo with mode 2.

--------------------------------------------------------
Request is made using the MODE_INFORMATION (1016) info level.  File is
referenced by NAME.
		Set file mode to 0.

		SMBTorture Output: None.

		Tests/Expectations:
			Server should respond with NT_STATUS_OK
			MODE_INFORMATION query response should show that the file mode is set
to 0.
		Notes:
			Same test as above except the file is referenced by name.

--------------------------------------------------------

Please point it out if the mistake.



More information about the samba-technical mailing list