Pseudobacklinks patches and related patches
esiotrot at gmail.com
Sun Jun 12 03:32:31 MDT 2011
On 11 June 2011 23:04, Matthieu Patou <mat at samba.org> wrote:
> Hello All,
> I'm planning to push patches from this branch in the main tree:
> The pseudobacklink part has been reviewed by Andrew Bartlett, I think I've
> addressed all his remarks. As the introduction of pseudobacklink means that
> existing provision will not have them, I've created a script to create them.
> A couple of patches are related to this scripts and to the problem I found
> with the handling of deleted objects.
> If someone wants to have a look at it just in case I left something. It
> would be very great to have this alpha16 as it would give the capability for
> our users to move DCs between sites.
There are a couple of cosmetic issues with the buildbacklink.py script:
on line 48, you have:
48 m = ldbs.sam.search(expression='namingContexts=*',
49 scope=ldb.SCOPE_BASE, base="")
but m does not seem to be used after that. On line 64 you have this:
64 m = ldbs.sam.search(expression='(dn=%s)' % str(dn),
65 controls=["search_options:1:2", "show_deleted:0"])
so it seems lines 48 and 49 are not needed?
Also the wrong script name is used on line 15 for the usage message.
Michael Wood <esiotrot at gmail.com>
More information about the samba-technical