Pseudobacklinks patches and related patches

[Michael Wood]

Hi

On 11 June 2011 23:04, Matthieu Patou <mat at samba.org> wrote:
> Hello All,
>
> I'm planning to push patches from this branch in the main tree:
> http://git.samba.org/?p=mat/samba.git;a=shortlog;h=refs/heads/pseudobacklinks
>
> The pseudobacklink part has been reviewed by Andrew Bartlett, I think I've
> addressed all his remarks. As the introduction of pseudobacklink means that
> existing provision will not have them, I've created a script to create them.
> A couple of patches are related to this scripts and to the problem I found
> with the handling of deleted objects.
>
> If someone wants to have a look at it just in case I left something. It
> would be very great to have this alpha16 as it would give the capability for
> our users to move DCs between sites.

There are a couple of cosmetic issues with the buildbacklink.py script:

In http://git.samba.org/?p=mat/samba.git;a=blob;f=source4/scripting/bin/buildbacklink.py;h=6d5e4903f089a567415663be6a237c516d43e570;hb=8a0966a585be3557b06d450d757f427f1f503c5f
on line 48, you have:

  48 m = ldbs.sam.search(expression='namingContexts=*',
attrs=["namingContexts"],
  49                     scope=ldb.SCOPE_BASE, base="")

but m does not seem to be used after that.  On line 64 you have this:

  64            m = ldbs.sam.search(expression='(dn=%s)' % str(dn),
  65                    controls=["search_options:1:2", "show_deleted:0"])

so it seems lines 48 and 49 are not needed?

Also the wrong script name is used on line 15 for the usage message.

-- 
Michael Wood <esiotrot at gmail.com>