Patch to export init_stat_ex_from_stat so that it can be used in VFS modules rather than duplicating code

Richard Sharpe realrichardsharpe at
Fri Jun 10 07:55:10 MDT 2011

On Fri, Jun 10, 2011 at 6:21 AM, Guenther Deschner <gd at> wrote:
> Hi Richard,

[some deletia]

>>> A better way of resolving this would be to split out the prototypes of
>>> the
>>> init_stat_ex_from_stat() call to a tiny separate header file for now, and
>>> include it only where really needed.
>>> Does that make sense ?
>> Well, it makes sense, but I am getting contradictory advice from
>> different team members :-)
> Ok, after looking at it again, I realized there is actually no need to add a
> global include at all. Adding forward declarations is absolutely sufficient
> here. Problem gone :-) I slightly modified your patch and pushed to
> autobuild.

D'oh! I should have thought of that.

Richard Sharpe

More information about the samba-technical mailing list