s3-param Remove special case for lp_workgroup()

Andrew Bartlett abartlet at samba.org
Thu Jun 9 16:33:16 MDT 2011


On Thu, 2011-06-09 at 15:22 +0200, Stefan (metze) Metzmacher wrote:
> Hi Andrew,
> 
> commit 3ccc7609476139bc6a906110a2623605f3802159 introduced a regression
> in rpcclient, which makes it unusable, as the lp_workgroup() returns
> uninitialized memory.
> 
> I have put a fix for this into autobuild, but it would be nice if you could
> add some blackbox tests for rpcclient, so that we'll detect things like
> this in future.

Thanks metze,

I'll write a basic blackbox test for rpcclient today.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list