The TALLOC_ wrappers.
abartlet at samba.org
Wed Jun 8 23:13:27 MDT 2011
On Mon, 2011-06-06 at 20:23 -0700, Jeremy Allison wrote:
> On Tue, Jun 07, 2011 at 12:29:55PM +1000, Andrew Bartlett wrote:
> > On Tue, 2011-05-31 at 11:09 +1000, Andrew Bartlett wrote:
> > > Jeremy,
> > >
> > > As I recall it, the TALLOC_ wrappers are your baby.
> > >
> > > I'm also wondering if could remove the TALLOC_ (except TALLOC_FREE)
> > > macros from the source3 code, which were added and then removed with an
> > > #if 0. These also makes merging code across the tree difficult, and
> > > seem pointless given their limited use (source3 only) and that the
> > > source3 has now fully accepted talloc's talloc(ctx, 0) behaviour.
> Sorry, meant to reply to this - +1 from me !
> > Jeremy,
> > I've prepared a series of patches that removes the majority of these
> > TALLOC_ wrapper functions, one patch per bulk rename.
> > This makes the Samba codebase much more internally consistent.
> > http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s3-talloc
> I'll try and get to this tomorrow.
Would it be OK if I get Tridge to review this? I just don't want to
have this outstanding for too long, because I'll need to fix it up for
every other change made under source3 in the meantime.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical