The TALLOC_ wrappers.
Jeremy Allison
jra at samba.org
Mon Jun 6 21:23:23 MDT 2011
On Tue, Jun 07, 2011 at 12:29:55PM +1000, Andrew Bartlett wrote:
> On Tue, 2011-05-31 at 11:09 +1000, Andrew Bartlett wrote:
> > Jeremy,
> >
> > As I recall it, the TALLOC_ wrappers are your baby.
> >
> > I'm also wondering if could remove the TALLOC_ (except TALLOC_FREE)
> > macros from the source3 code, which were added and then removed with an
> > #if 0. These also makes merging code across the tree difficult, and
> > seem pointless given their limited use (source3 only) and that the
> > source3 has now fully accepted talloc's talloc(ctx, 0) behaviour.
Sorry, meant to reply to this - +1 from me !
> Jeremy,
>
> I've prepared a series of patches that removes the majority of these
> TALLOC_ wrapper functions, one patch per bulk rename.
>
> This makes the Samba codebase much more internally consistent.
>
> http://git.samba.org/?p=abartlet/samba.git/.git;a=shortlog;h=refs/heads/s3-talloc
I'll try and get to this tomorrow.
Jeremy.
More information about the samba-technical
mailing list