Reformatting code

Jeremy Allison jra at
Fri Jul 22 10:57:06 MDT 2011

On Fri, Jul 22, 2011 at 11:14:54AM +0200, Stefan (metze) Metzmacher wrote:
> In the last days I saw a lot of really ugly code, while doing the
> libsmb cleanups (which prepare multiprotcol (smb1/smb2) support).
> And I think it's ok to fix format related stuff, when someone
> works on the related code. (Still we should not abuse this).

Thanks for the cleanups, it's old code. But you should realize
that in 5 years time someone will come across your new code in
libsmb and think "how ugly, I must clean this up". The funny
thing is it'll probably be you :-).


More information about the samba-technical mailing list