Disable SMB2 for 3.6?
Volker.Lendecke at SerNet.DE
Fri Jul 8 05:19:16 MDT 2011
On Thu, Jul 07, 2011 at 01:38:27PM -0700, Jeremy Allison wrote:
> > Metze - do you have an opinion as to whether your patch produces
> > the clearest way to get maintainable code ? I'm assuming you
> > want the become_root() calls inline ?
> > Volker - would it help if the function smbd_smb2_request_check_tcon()
> > was moved out of smbd/smb2_tcon.c and into smbd/smb2_server.c
> > and the same for smbd_smb2_request_check_session() (move out of
> > smbd/smb2_sessetup.c into smbd/smb2_server.c) as it would make
> > the validation functions locally located to the dispatch function
> > that has to call them to check security ? Right now they are
> > located in the files that are named after the code that processes
> > the request, which makes sense from a naming point of view, but
> > not from a logic point of view - these functions are validation
> > code, not request processing code. If we moved them both into
> > smbd/smb2_server.c to just above smbd_smb2_request_dispatch()
> > they could both be make static to that file.
> > Volker, your opinion is most valuable, as you're the one who
> > found this bug - which is most definitely a show-stopper for
> > release (the very definition in fact :-).
> Here is the diff against master that moves the check_ functions
> into smbd/smb2_server.c. Volker and Metze please comment on your
> opinions on this.
Not strictly required, but (IMHO very) nice to have.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical