Disable SMB2 for 3.6?

[Jeremy Allison]

On Thu, Jul 07, 2011 at 05:05:46PM +0200, Volker Lendecke wrote:
> 
> On Thu, Jul 07, 2011 at 11:01:10AM -0400, simo wrote:
> > > It might fix it, but the fact that this went undetected for
> > > so long makes this non-shippable IMO.
> > 
> > 
> > SMB2 is one of the key features of 3.6.0, if it is not ready it is a
> > blocker for the release IMO.
> 
> We just can't ship if SMB2 is compiled in. The basic
> architecture of the server is many months old, and nobody
> detected this flaw. There have been many improvements in 
> 3.6, so I think shipping 3.6 without
> SMB2 is still worth it. SMB2 should wait until 4.0.

No, I don't think we can do that. Let me look at metze's
patch. As metze said, the default of "max protocol = NT1"
will protect against most errors of this kind.

Jeremy.