Disable SMB2 for 3.6?

[simo]

On Thu, 2011-07-07 at 16:54 +0200, Volker Lendecke wrote:
> On Thu, Jul 07, 2011 at 04:48:52PM +0200, Stefan (metze) Metzmacher wrote:
> > > In response to a user bug report I've discovered a deep
> > > architectural flaw in our SMB2 server: The credential
> > > handling is not cleanly done in a central place but spread
> > > out over way too many places. The symptom is that a
> > > secondary tcon happens to be called as the user who has
> > > issued the last SMB2 request, not as root as it has been
> > > done in SMB1. This breaks quite some assumptions deep inside
> > > our code. Finding such an architectural flaw at this late
> > > stage in the release process scares me to death. So I would
> > > strongly recommend that we disable compiling SMB2 in by
> > > default and only enable it as highly experimental for 3.6.0.
> > 
> > This patch should fix the problem:
> > http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=f2806cca536de82739
> 
> It might fix it, but the fact that this went undetected for
> so long makes this non-shippable IMO.


SMB2 is one of the key features of 3.6.0, if it is not ready it is a
blocker for the release IMO.

Simo.

-- 
Simo Sorce
Samba Team GPL Compliance Officer <simo at samba.org>
Principal Software Engineer at Red Hat, Inc. <simo at redhat.com>