Disable SMB2 for 3.6?

[Volker Lendecke]

On Thu, Jul 07, 2011 at 04:48:52PM +0200, Stefan (metze) Metzmacher wrote:
> > In response to a user bug report I've discovered a deep
> > architectural flaw in our SMB2 server: The credential
> > handling is not cleanly done in a central place but spread
> > out over way too many places. The symptom is that a
> > secondary tcon happens to be called as the user who has
> > issued the last SMB2 request, not as root as it has been
> > done in SMB1. This breaks quite some assumptions deep inside
> > our code. Finding such an architectural flaw at this late
> > stage in the release process scares me to death. So I would
> > strongly recommend that we disable compiling SMB2 in by
> > default and only enable it as highly experimental for 3.6.0.
> 
> This patch should fix the problem:
> http://gitweb.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=f2806cca536de82739

It might fix it, but the fact that this went undetected for
so long makes this non-shippable IMO.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen