sec_initial_uid() check in debug.c:check_log_size()

Andrew Bartlett abartlet at samba.org
Tue Jul 5 23:12:16 MDT 2011


On Tue, 2011-07-05 at 08:21 +0200, Volker Lendecke wrote:
> On Tue, Jul 05, 2011 at 11:11:40AM +1000, Andrew Bartlett wrote:
> > In commit 644222a1e36d18f8a57f815e74a08a78c26abb89 you added back a
> > sec_initial_uid() check for log rotation in the common debug code, with
> > the message:
> > 
> > > debug: Restore the s3-style check in check_log_size()
> > > This has caused me considerable grief.
> > 
> > Would it be possible for you to explain what exactly you were trying to
> > do that caused this to be a problem, and what the problem was, so I can
> > see if I can resolve it another way? 
> 
> IIRC make test did not re-open logs properly. Please keep
> it that way.

Ahh, that makes sense now.  Given that 'make test' now only logs to
stdout, avoiding the need to reopen logs, can we remove the #ifdef
_SAMBA_BUILD_ == 3?

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett <abartlet at samba.org>



More information about the samba-technical mailing list