patch allowing correct linked attribute update

Andrew Bartlett abartlet at samba.org
Mon Jul 4 05:30:38 MDT 2011


On Sun, 2011-07-03 at 22:58 +0400, Matthieu Patou wrote:
> Hello,
> 
> I faced problem with dbcheck, some of my linked attributes (member) 
> where not 100% correct (missing SID) deleting the old value and readding 
> it didn't make the trick because we still use the old DN (making the 
> assumption that it is correct).
> 
> The attached patch change this by always taking the DN attributes (guid, 
> sid, non extended dn string) from the new DN.

I've looked at this very carefully, and I think you are correct.  Well spotted!

I would use p-> rather than dns[i] when specifying the DN from the
incoming replacement values, but other than that, I think it's good.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list