Strangeness in reply.c:copy_file()

Jeremy Allison jra at samba.org
Wed Jan 26 15:37:53 MST 2011


On Sun, Jan 23, 2011 at 08:44:46PM +0100, David Disseldorp wrote:
> Hi,
> 
> Looking into printer driver issues, I ran across some peculiarities in
> copy_file():
> - Firstly, if the source file is zero bytes, NT_STATUS_DISK_FULL is
>   returned.
> - Secondly, the conditional lseek is confusing. It fires when
>   OPENX_FILE_EXISTS_OPEN is set and I can't see why the lseek is
>   necessary in this case.
> - Finally, the lseek error path also results in NT_STATUS_DISK_FULL.
> 
> Proposed fix for first and third point below.

Looks good to me - pushing - thanks !


More information about the samba-technical mailing list