s3: Fix an infinite loop

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Jan 24 01:29:06 MST 2011


On Mon, Jan 24, 2011 at 09:14:23AM +0100, Stefan (metze) Metzmacher wrote:
> I think this change is wrong because, selret is a pointer and we already
> have this check (directly above):

Gna. I have first done this in 3.5, where selrtn is not a
pointer. I have then just taken the same patch and applied
it to master, wrongly assuming that this is the same piece
of code. The patch applied cleanly, so I did not check.
Apologies for this false assumption.

By the way, where does 3.5 handle the selrtn==-1 case?

I have just pushed the revert to autobuild.

With best regards,

Volker Lendecke

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen


More information about the samba-technical mailing list