s4-repl_meta_data: We should not use USNs in metadata comparisons

Andrew Bartlett abartlet at samba.org
Sat Jan 22 15:45:02 MST 2011


On Sat, 2011-01-22 at 12:23 +0100, Kamen Mazdrashki wrote:
> The branch, master has been updated
>        via  585e9a0 s4-repl_meta_data: replmd_update_is_newer() should not return true if metadata stamps are equal
>        via  0ce93ad s4-repl_meta_data: Print out what is wrong when we fail to modify object
>        via  0aa118f s4-repl_meta_data: We should not use USNs in metadata comparisons
>       from  6ee39a2 s3-torture: fix uninitialized status code.
> 
> http://gitweb.samba.org/?p=samba.git;a=shortlog;h=master

Kamen,

Do you have some tests to show that this is incorrect?  Tridge and I put
a fair bit of care into this function, and it was informed by the docs.
What information do you have that it was incorrect?

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Cisco Inc.



More information about the samba-technical mailing list