bug 7836: fix printcap cache race conditions

Andreas Schneider asn at cynapses.org
Fri Jan 7 13:47:04 MST 2011


On Monday, January 03, 2011 11:41:46 David Disseldorp wrote:
> On Sun, 2 Jan 2011 22:33:50 +0100
> 
> Björn Jacke <bj at SerNet.DE> wrote:
> > Hi,
> > 
> > for 3.6 and master, please use time_mono(), not time() for
> > calculation of timeouts to make printer timeouts not go mad when the
> > system clock is being adjusted. You can find several examples of
> > time_mono() usage at other places. If the timeout does not interact
> > with any variables that must contain realtime clock values then the
> > use of the monotonic clock is quite straightforward. Can you update
> > the patch for master accordingly?
> 
> Thanks for the feedback Björn, new patch pushed and attached.

Hi Jeremy,

I've did a review today and suggested some small improvements. The patches 
looks good for me. Please review and push when you're fine again.

Cheers,


	-- andreas



More information about the samba-technical mailing list